Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected test when loading rdfs. It used type for is_a. #796

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

francescalb
Copy link
Collaborator

Description

A bugfix in 0wlready2==0.46 corrected reutning what is returned when using type on dataclasses.
We had used type instead of is_a in the test and this has now been corrected.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (d3f8e88) to head (73bc4fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   72.63%   72.61%   -0.03%     
==========================================
  Files          18       18              
  Lines        3706     3706              
==========================================
- Hits         2692     2691       -1     
- Misses       1014     1015       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from flb/owlready0.45 to master October 29, 2024 13:34
@francescalb francescalb merged commit ae79ed4 into master Oct 29, 2024
11 of 12 checks passed
@francescalb francescalb deleted the flb/owlready0.46 branch October 29, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants