Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Envoy, go-control-plane, Go, and dependencies #5807

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Update Envoy, go-control-plane, Go, and dependencies #5807

merged 12 commits into from
Dec 5, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Dec 5, 2024 •
edited
Loading

This PR does several nontrivial things in preparation for 3.10.0-rc.1:

  • Update Envoy to Ambassador’s Envoy 1.31.3 build (github.com/datawire/envoy commit 628f5afc)
  • Update go-control-plane to match
  • Update Go dependencies (notably google.golang.org/grpc) to match go-control-plane
  • Update Go itself to 1.23.3
  • Update CI and KAT test images to use Ubuntu 24.04 (since the old Ubuntu was decommissioned)
  • Rewrite create_crl_pem_b64 in python/test/utils.py to use the cryptography module since PyOpenSSL is deprecated and its CRL module was decommissioned

As usual, this is likely best reviewed commit by commit.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Dec 5, 2024
kflynn added 9 commits December 4, 2024 22:52
@kflynn
Switch KAT to Ubuntu 24.04. Clean up Docker lint stuff
9f6c9b5 
Signed-off-by: Flynn <[email protected]>
@kflynn
Switch GitHub workflows to ubuntu-24.04
8e7ee3b 
Signed-off-by: Flynn <[email protected]>
@kflynn
Update ENVOY_COMMIT and ENVOY_GO_CONTROL_PLANE_COMMIT
dfcf012 
Signed-off-by: Flynn <[email protected]>
@kflynn
Bump google.golang.org/grpc (to get grpc.NewClient for go-control-pla…
c55dad2 
…ne) and go mod tidy.

Signed-off-by: Flynn <[email protected]>
@kflynn
Switch to Golang 1.23.3
33a9ce8 
Signed-off-by: Flynn <[email protected]>
@kflynn
gmake compile-envoy-protos
a47f748 
Signed-off-by: Flynn <[email protected]>
@kflynn
Fix make generate
233307c 
Signed-off-by: Flynn <[email protected]>
@kflynn
gmake generate
c9a542b 
Signed-off-by: Flynn <[email protected]>
@kflynn
Switch to the GCR mirror for the base Envoy image
95495a5 
Signed-off-by: Flynn <[email protected]>
@kflynn kflynn force-pushed the flynn/update branch 2 times, most recently from b94152e to 45dce5d Compare December 5, 2024 04:00
@kflynn kflynn requested a review from a team December 5, 2024 04:37
@kflynn kflynn mentioned this pull request Dec 5, 2024
Merged
Alice-Lilith
Alice-Lilith approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Alice-Lilith Alice-Lilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for updating all this 🙂

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@kflynn kflynn merged commit 20e3f63 into master Dec 5, 2024
39 checks passed
@kflynn kflynn deleted the flynn/update branch December 5, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alice-Lilith Alice-Lilith Alice-Lilith approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kflynn @Alice-Lilith