Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keepalive gunicorn #4008

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keepalive gunicorn #4008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc905d1
fix: set diagd gunicorn keepalive to 300s
jasons42 Jan 12, 2022
0b190fd
docs: update relase notes
jasons42 Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/releaseNotes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ items:
Support for the Envoy V2 API and the `AMBASSADOR_ENVOY_API_VERSION` environment
variable have been removed. Only the Envoy V3 API is supported (this has been the
default since Emissary-ingress v1.14.0).

- title: DiagD internal tcp idle timeout tuning
type: change
body: >-
Set the diagd tcp idle timeout (i.e. keepalive timeout) to 300s, up from the
gunicorn default of 2s. This should help eliminate race-conditions where
probing `/ambassador/v0/check_alive` may intermittently fail.

- version: 2.1.0
date: '2021-12-16'
Expand Down
1 change: 1 addition & 0 deletions python/ambassador_diag/diagd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,6 +2162,7 @@ def _main(snapshot_path=None, bootstrap_path=None, ads_path=None,
'bind': '%s:%s' % (host, port),
# 'workers': 1,
'threads': workers,
'keepalive': 300,
}

app.logger.info("thread count %d, listening on %s" % (gunicorn_config['threads'], gunicorn_config['bind']))
Expand Down