Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of current order of filters:
when ext_auth returns 4xx (or it fails because of whatever other reasons) the cors handler is not called and no cors headers are injected (for example access-control-allow-origin) - because of that browser is not able to handle such response gently.
I first tested if reordering of these filters will help, using plain envoy, and following configuration gave me expected result - cors where injected even if ext-auth returned 4xx (it makes sense because cors is handled first)
then I tried do the same with Ambassador Intermediate Representation - and It also works.
Testing
Tested on stage env (kubernetes).
Checklist
I am not filling this section yet.