Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idle mapping timeout with same value than timeout #3383

Open
wants to merge 10,000 commits into
base: master
Choose a base branch
from
Open

Idle mapping timeout with same value than timeout #3383

wants to merge 10,000 commits into from

Conversation

maticue
Copy link

@maticue maticue commented May 3, 2021

Description

idle_timeout mapping is per default 5 minutes. However, there might be some knative uses cases where channel might require more idle time.
This PR sets same idle_timeout_ms than timeout_ms knative mapping.

Related Issues

Testing

Created a custom aes docker image with idle_timeout_ms set on same value we have on timeout_ms. I was able to keep idle connections for more than 5 minutes.

Tasks That Must Be Done

  • Did you update CHANGELOG.md?
    • Is this a new feature?
    • Are there any non-backward-compatible changes?
    • Did the envoy version change?
    • Are there any deprecations?
    • Will the changes impact how ambassador performs at scale?
      • Might an existing production deployment need to change:
        • memory limits?
        • cpu limits?
        • replica counts?
      • Does the change impact data-plane latency/scalability?
  • Is your change adequately tested?
    • Was their sufficient test coverage for the area changed?
    • Do the existing tests capture the requirements for the area changed?
    • Is the bulk of your code covered by unit tests?
    • Does at least one end-to-end test cover the integration points your change depends on?
  • Did you update documentation?
  • Were there any special dev tricks you had to use to work on this code efficiently?
    • Did you add them to DEVELOPING.md?
  • Is this a build change?
    • If so, did you test on both Mac and Linux?

Other

  • If this is a documentation change for a particular release, please open the pull request against the release branch.

acookin and others added 30 commits March 22, 2021 21:42
@acookin
use chart tags to drive releases
07fc9e1
@jfrabaute
Add diagnostics.allow_non_local feature
ad415e4 
This option allows to expose the diag UI to non-local clients, even when
the diag UI is disabled.

Implements emissary-ingress#3074
rm submod; prune unused scripts and environment
92e8272
@acookin
no chart CI for RCs
6ca3383
Split chart setup and chart processing
3ee8730
better chart-version check
6c719f2
Don't overwrite chart versions
e169dae
Update CHANGELOG
9e0bbb0
@acookin
generate circle config
13965de
@esmet
(from AES) Support merge_slashes on the Ambassador Module to expose t…
4fca3b4 
…he same functionality in Envoy
@acookin
(from AES) fix agent datarace sadness (emissary-ingress#2472)
865036a
Oops. Match chart-vX.Y.Z instead of chart-test-vX.Y.Z.
d1be62d
Oops. Update the chart version of the Mapping CRD.
17de7fb
@kflynn
Merge pull request emissary-ingress#3287 from jfrabaute/allow_non_local
49135df 
Add diagnostics.allow_non_local feature
@kflynn
Merge pull request emissary-ingress#3268 from datawire/acookin/merge-…
903a392 
…chart-repo

merge chart repo
(from AES) Merge branch 'master' into rhs/parse_service_scheme_fix
18ac35c
(from AES) Merge commit '903a392329efa4130c105645aa84f17d12c7cb27' in…
924687b 
…to flynn/dev/chart-merge
(from AES) Implement rollout watcher in agent
d91fbe0
(from AES) address code review comments
7356e0d
(from AES) fix agent-e2e test rollout validation
224b9e0
Adding ReplicaSet + PodTemplateSpec aliases to kates
9d653a4
(from AES) Fix k8s-aes CRD files
7b7620d
(from AES) Remove the rollout addition to the deltas while reporting …
485004a 
…to AgentCom
(from AES) Merge pull request emissary-ingress#2469 from datawire/mer…
f09ae4a 
…ge-slashes

Support merge_slashes on the Ambassador Module to expose the same functionality in Envoy
@iNoahNothing
use correct spelling
1acdf63 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Resolvers are used for oss ambassador as well
beebc54 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Add a test for creating resolvers
28ab7e7 
Signed-off-by: Noah Krause <[email protected]>
Merge pull request emissary-ingress#3305 from datawire/donnyyung/add-…
3fcca66 
…rs-kates

Adding ReplicaSet + PodTemplateSpec aliases to kates
@iNoahNothing
Update chart and changelog
95c5b34 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Move the test to the right spot 🤦
feeb3de 
Signed-off-by: Noah Krause <[email protected]>
Rafael Schloming and others added 29 commits April 22, 2021 10:40
(from AES) Update for v1.13.1
bea6dcd
Merge pull request emissary-ingress#3360 from datawire/rel/v1.13.1
3c1370f 
Rel/v1.13.1
Adjust the website stuff for repatriation back in to master
b88dc7e
Merge remote-tracking branch 'origin/master' into rhs/repatriate
04066f0
Merge pull request emissary-ingress#3361 from datawire/rhs/repatriate
1384b18 
Rhs/repatriate
@acookin
fix single namespace rbac (emissary-ingress#3364)
0ed0ed5
@acookin
bumping chart and changelog for v6.7.2 (emissary-ingress#3370)
528562f
@acookin
(from AES) [1.13.2] parse annotations correctly in go entrypoint (emi…
e09d755 
…ssary-ingress#2599)

* parse annotations correctly in go entrypoint

* and lots o tests

* update changelog
@acookin
(from AES) Merge commit '3c1370f7f2c9d97f7c4105bbb76e3859df9e69d5' in…
64c8423 
…to rel/v1.13.2
@acookin
(from AES) Update for v1.13.2-rc.0
5e72568
@acookin
(from AES) chart updates for 1.13.2
fbb83cb
@acookin
(from AES) Update for v1.13.2
915b171
@acookin
(from AES) fix changelog
6831d4b
@iNoahNothing
fix values layout
ed32005 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Add module management to the chart
97cacf2 
Signed-off-by: Noah Krause <[email protected]>
@acookin
fix single namespace rbac (emissary-ingress#3364)
1f2b49c
@acookin
bumping chart and changelog for v6.7.2 (emissary-ingress#3370)
9622bbb
@acookin
undo bad cherry pick
953476b
@iNoahNothing
Update CHANGELOG
cc20b65 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Update chart and CHANGELOG
4651541 
Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Update README
967bb41 
Signed-off-by: Noah Krause <[email protected]>
@acookin
Merge pull request emissary-ingress#3371 from datawire/rel/v1.13.2
c682514 
Rel/v1.13.2
@acookin
Adjust the website stuff for repatriation back in to master
93a102d
@acookin
Merge remote-tracking branch 'origin/master' into acook/repatriate
a2435fd
@iNoahNothing
Add test
77bab8d 
Signed-off-by: Noah Krause <[email protected]>
@acookin
Merge pull request emissary-ingress#3373 from datawire/acook/repatriate
5bf1dbe 
1.13.2 repatriation
@iNoahNothing
Merge branch 'master' of github.com:datawire/ambassador into nkrause/…
3148c82 
…module

Signed-off-by: Noah Krause <[email protected]>
@iNoahNothing
Merge pull request emissary-ingress#3374 from datawire/nkrause/module
f84dcce 
Add module management to the chart
@maticue
Idle mapping timeout with same value than timeout
e621a8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.