-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Manager Service Mesh Configuration in the Helm Chart #3367
Draft
iNoahNothing
wants to merge
10
commits into
master
Choose a base branch
from
nkrause/servicemesh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
…servicemesh Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
Signed-off-by: Noah Krause <[email protected]>
I should probably write tests for this since there is actually a lot going on here 😞 |
iNoahNothing
changed the title
Manager Service Mesh Configuration in the Helm Chart
[WIP]Manager Service Mesh Configuration in the Helm Chart
Apr 29, 2021
LukeShu
force-pushed
the
nkrause/servicemesh
branch
from
May 8, 2021 23:51
eb0e808
to
1f2dc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates new values for creating and managing the extra config needed to integrate with Istio and Consul Connect service meshes to the chart.
Previously, the Consul Connector needed to be managed separately and the Istio sidecar injection needed to be done with a combination of different values. This PR makes it so Helm can automatically manage these resources.
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Tasks That Must Be Done