Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Manager Service Mesh Configuration in the Helm Chart #3367

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

iNoahNothing
Copy link
Contributor

Description

This PR creates new values for creating and managing the extra config needed to integrate with Istio and Consul Connect service meshes to the chart.

Previously, the Consul Connector needed to be managed separately and the Istio sidecar injection needed to be done with a combination of different values. This PR makes it so Helm can automatically manage these resources.

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Tasks That Must Be Done

  • Did you update CHANGELOG.md?
    • Is this a new feature?
    • Are there any non-backward-compatible changes?
    • Did the envoy version change?
    • Are there any deprecations?
    • Will the changes impact how ambassador performs at scale?
      • Might an existing production deployment need to change:
        • memory limits?
        • cpu limits?
        • replica counts?
      • Does the change impact data-plane latency/scalability?
  • Is your change adequately tested?
    • Was their sufficient test coverage for the area changed?
    • Do the existing tests capture the requirements for the area changed?
    • Is the bulk of your code covered by unit tests?
    • Does at least one end-to-end test cover the integration points your change depends on?
  • Did you update documentation?
  • Were there any special dev tricks you had to use to work on this code efficiently?
    • Did you add them to DEVELOPING.md?
  • Is this a build change?
    • If so, did you test on both Mac and Linux?

@iNoahNothing iNoahNothing requested a review from acookin April 27, 2021 21:19
@iNoahNothing
Copy link
Contributor Author

I should probably write tests for this since there is actually a lot going on here 😞

@iNoahNothing iNoahNothing changed the title Manager Service Mesh Configuration in the Helm Chart [WIP]Manager Service Mesh Configuration in the Helm Chart Apr 29, 2021
@iNoahNothing iNoahNothing removed the request for review from acookin April 29, 2021 18:33
@LukeShu LukeShu force-pushed the nkrause/servicemesh branch from eb0e808 to 1f2dc52 Compare May 8, 2021 23:51
@LukeShu LukeShu marked this pull request as draft January 27, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant