Add insertion_order and color_conflict_handling to Legend
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoxc
changed the title
insertion_order and color_conflict_prefer_last to Legendinsertion_order and color_conflict_handling to Legend
emilk
reviewed
Sep 26, 2024
| @@ -86,6 +99,23 @@ impl Legend { | |||
| self.hidden_items = Some(hidden_items.into_iter().collect()); | |||
| self | |||
| } | |||
|
|
|||
| /// Specifies if the legend item order should be the inserted order. | |||
There was a problem hiding this comment.
as opposed to what?
maybe this should also be an enum?
There was a problem hiding this comment.
The legends currently get sorted due to the b-tree.
There was a problem hiding this comment.
maybe add another doc comment here
bircni
suggested changes
Dec 4, 2024
| @@ -86,6 +99,23 @@ impl Legend { | |||
| self.hidden_items = Some(hidden_items.into_iter().collect()); | |||
| self | |||
| } | |||
|
|
|||
| /// Specifies if the legend item order should be the inserted order. | |||
There was a problem hiding this comment.
maybe add another doc comment here
|
I feel like this needs an image to explain what is going on, and maybe a demo/example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertion_orderlets the user pick the legend order.color_conflict_handlingstill allows a color to be specified in case of conflicts.