New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make demo a bit more mobile friendly #44

Merged

emilk merged 1 commit into emilk:main from BGR360:fix-demo-on-mobile

Sep 10, 2024

Contributor

BGR360 commented Sep 10, 2024

Change ui.horizontal() to ui.horizontal_wrapped() for the PlotDemo selector so it doesn't go off screen.
Wrap several of the demo's "settings" UI's in a ScrollArea::horizontals so they don't go off screen and make the plots go off screen as well.
Wrap the plots in the LinkedAxes demo in a ScrollArea::horizontal so they don't go off screen.

Before and after screenshots

Lines

Before:

After:

Legend

Before:

After:

Charts

Before:

After:

Linked Axes

Before:

After:


          [demo] Fix UI overflowing the screen on mobile.

69ae751

BGR360 commented

View reviewed changes

Contributor Author

BGR360 left a comment

Doing a self review as suggested in CONTRIBUTING.md. LGTM 😅

emilk approved these changes

View reviewed changes

emilk added exclude from changelog examples labels

emilk changed the title ~~[demo] Fix UI overflowing the screen on mobile.~~ Make demo a bit more mobile friendly

emilk merged commit 1e7fd71 into emilk:main

8 of 9 checks passed

Owner

emilk commented Sep 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples exclude from changelog