Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize editing multi-line text #5560

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Optimize editing multi-line text #5560

wants to merge 30 commits into from
+396 −141

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jan 2, 2025 •
edited
Loading

Splits long layout jobs into paragraphs (i.e. splits on \n). When editing, only edited lines will be laid out again; the others will already be in the cache.

afishhh and others added 27 commits November 28, 2024 16:47
@afishhh
Fix typo
622b848
@afishhh
Cache individual lines of text in GalleyCache
150c0f6
@afishhh
Make Galleys share Rows and store their offsets
db32a1e
@afishhh
Fix lints
4e3f162
@afishhh
Don't add leading space to more than one split layout section
3de1723
@afishhh
Move cached-multiline-layout code into a helper function
f028154
@afishhh
Properly handle row repositioning
bc86bec
@afishhh
Correctly handle empty lines
abbc561
@afishhh
Respect first_row_min_height during multiline Galley layout
6d6bc3b
@afishhh
Round PlacedRow positions to pixels during multiline layout
6147ff3
@afishhh
Move ends_with_newline back into Row
66c83c3
@afishhh
Respect LayoutJob::round_output_size_to_nearest_ui_point
1be24ba
@afishhh
Simplify layout_multiline loop loop into a while loop
fd8413c
@afishhh
Fix Row::ends_with_newline docs, explain skipping of last galley row
bbe5662
@afishhh
Move some PlacedRow methods back to Row
110a9c3
@afishhh
Replace a hack with a proper implementation
139f286
@afishhh
Slightly simplify paint_text_selection code
e15b34b
@afishhh
Fix nits
c6592ec
@afishhh
Fix text horizontal alignment
25da822
@afishhh
Add comment and check for newline before multiline layout
40f237d
@afishhh
Fix incorrect behavior with LayoutJob::max_rows
17a5f1f
@afishhh
Merge branch 'emilk:master' into cache_galley_lines
c094ee8
@afishhh
Add benchmark
3e1ed18
@afishhh
Merge branch 'master' into cache_galley_lines
ec9a408
@emilk
Merge branch 'master' into cache_galley_lines
d2f75e9
@emilk
Better benchmark
2b53271
@emilk
Merge branch 'master' into cache_galley_lines
ba2ae9d
@emilk emilk marked this pull request as draft January 2, 2025 01:12
@emilk emilk changed the title Cache galley lines Optimize editing multi-line text Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Preview available at https://egui-pr-preview.github.io/pr/5560-cachegalleylines
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk mentioned this pull request Jan 2, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @afishhh