Add WidgetType::Image and Image::alt_text
#5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5534-lucasimage-widget-type |
lucasmerlin
changed the title
WidgetType::ImageWidgetType::Image and Image::alt_text
lucasmerlin
force-pushed
the
lucas/image-widget-type
branch
from
5458595 to
4a8ed33
Compare
lucasmerlin
force-pushed
the
lucas/image-widget-type
branch
from
4a8ed33 to
dfb44f0
Compare
Co-authored-by: Emil Ernerfeldt <[email protected]>
lucasmerlin
force-pushed
the
lucas/image-widget-type
branch
from
3f71c16 to
3d1db8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
WidgetType::Imageand correctly sets it in the Image widget. This allows us to query for images in kittest tests and tells accesskit that a node is an image.It also adds
Image::alt_textto set a text that will be shown if the image fails to load and will be read via screen readers. This also allows us to query images by label in kittest.