Fix interactive widgets sometimes being incorrectly marked as hovered #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An interactive widget should only be marked hovered if a click/drag would start an interaction with it. egui 0.30 introduced a feature where a thin interactive widget could be hit even if it was partially behind a larger interactive widget. Unfortunately, this introduced a bug where the top widget would still be marked as hovered, even though a click would go through to the thin widget below. This bug was most notacible when trying to reisize a window by dragging its corner, which often would result in dragging one of its sides instead. This PR fixes this bug.
|
Preview available at https://egui-pr-preview.github.io/pr/5523-emilkfix-wrong-hovered |
emilk
added a commit
that referenced
this pull request
Dec 27, 2024
This makes it easier to hit the corners. Previously the corner response-area was covered by the response-areas of the edges. * Related to #5523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interactive widget should only be marked hovered if a click/drag would start an interaction with it.
egui 0.30 introduced a feature where a thin interactive widget could be hit even if it was partially behind a larger interactive widget. Unfortunately, this introduced a bug where the top widget would still be marked as hovered, even though a click would go through to the thin widget below.
This bug was most notacible when trying to reisize a window by dragging its corner, which often would result in dragging one of its sides instead.
This PR fixes this bug.