-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken images on egui.rs (move from git lfs to normal git) #5480
Conversation
1d89c8e
to
bdfed24
Compare
Preview available at https://egui-pr-preview.github.io/pr/5480-emilkfix-images-maybe |
Could it be that things aren't checked out with lfs for the web build? The error suggests that image couldn't detect the format which would make sense if the image has the lfs text contents |
I really dont want to intervene here, but @lucasmerlin might be right. I cannot even open the image with my standard image viewer. If i copy the image from the eframe/data to egui_demo_lib/data it works. |
@InfoInnovator if you have this problem locally, make sure you have properly setup git lfs. |
My bad. I didnt expect somebody to use lfs for a small PNG and didnt know of the guide. After pulling the lfs files, the web demo works as intended. |
Ah, then we should mark the .png:s used for the demo as non-lfs, and also see if we can improve the error message (does lfs links start with some magic bytes?) |
I think so:
|
edf1f11
to
248a30b
Compare
The images in the widget gallery on egui.rs are broken:
Not sure why yet, and I fail to reproduce locally.It's because they are on git lfs.