Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive widgets are only hovered if clicking would interact #5472

Closed
wants to merge 1 commit into from
Closed

Interactive widgets are only hovered if clicking would interact #5472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/egui/src/interaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ pub(crate) fn interact(
.copied()
.collect()
} else {
// We may be hovering a an interactive widget or two.
// We may be hovering an interactive widget or two.
// We must also consider the case where non-interactive widgets
// are _on top_ of an interactive widget.
// For instance: a label in a draggable window.
Expand All @@ -275,6 +275,11 @@ pub(crate) fn interact(
let mut hovered: IdSet = hits.click.iter().chain(&hits.drag).map(|w| w.id).collect();

for w in &hits.contains_pointer {
if w.sense.click || w.sense.drag {
// Interactive widgets are only marked as hover if they are the ones
// selected by the hit-test, and those have already been included.
continue; // TODO: what implications does this have for tooltips? :/
}
if top_interactive_order <= order(w.id).unwrap_or(0) {
hovered.insert(w.id);
}
Expand Down
Loading