Animated WebP support #5470
Open
Animated WebP support #5470
+301
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5470-animated-webp |
|
Needed this feature for a project I'm working on, currently using this branch as a dependency. So as far as testing goes, everything has been working as expected. All the quirks I came across were ironed out pre-PR. |
emilk
reviewed
Dec 17, 2024
examples/images/src/cat.webp
Outdated
There was a problem hiding this comment.
Let's make sure this is on git lfs
There was a problem hiding this comment.
I tried to fix this for you, but failed:
Pushing to github.com:Aely0/egui
error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'github.com:Aely0/egui'
You need to run this:
git lfs track examples/images/screenshot.png
git lfs track examples/images/src/cat.webp
git checkout .gitattributes
git add -u
git commit -m "Move images onto git lfs"
git push
There was a problem hiding this comment.
Done, though strange why you were not able to push to this branch
I thought that was the whole point of this checkbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for animated WebP images. Used the already existing GIF implementation as a template for most of it.