Workaround for egui having wrong scale in firefox #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucasmerlin
commented
Dec 12, 2024
•
lucasmerlin
commented
- I have followed the instructions in the PR template
lucasmerlin
added
web
|
Preview available at https://egui-pr-preview.github.io/pr/5466-lucasdevice-pixel-ratio-workaround |
lucasmerlin
force-pushed
the
lucas/device-pixel-ratio-workaround
branch
from
3941bd2 to
bb0d600
Compare
jprochazk
approved these changes
Dec 16, 2024
|
https://www.egui.rs/#rendering is now failing on chromium
Text is blurry, lines are not pixel-aligned |
|
It looks fine on Linux Chromium: |
|
Even when you zoom? ctrl+ etc also… that image does not look very crisp, but maybe that's just the screenshot tool? |
emilk
added a commit
that referenced
this pull request
Dec 16, 2024
* Reverts #5466 Restores pixel-perfect rendering on chromium, Mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.