Allow attaching custom user data to a screenshot command #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5416-emilk/screenshot-context |
1 task
emilk
commented
Dec 1, 2024
emilk
force-pushed
the
emilk/screenshot-context
branch
from
1c0b022 to
beb9ad5
Compare
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Dec 3, 2024
### Related * Closes #3941 * Uses emilk/egui#5416 * Uses emilk/egui#5426 * Follow-up: #8264 ### What Right-click the name of any space view to get the option to copy its contents as a screenshot, or save it to disk:  ->  #### Details The implementation simply takes a full-screen screenshot and crops the result. The previous attempt (behind a feature-flag) only captured things that were rendered with `re_renderer`, i.e. did not include any egui elements, like labels. So it also only worked on spatial views. This PR work on _all_ space views, and could also be extended to work on containers etc. ### Limitations Not yet implemented on web. See #8264 ### TODO * [x] Point commit hash to egui `master` --------- Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users trigger a screenshot from anywhere, and then when they get back the results they have some context about what part of their code triggered the screenshot.