Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all links to the demo website #5398

Closed
wants to merge 1 commit into from

Conversation

tguichaoua
Copy link
Contributor

  • I have followed the instructions in the PR template

The demo website use the hash part of the url to open a specific demo. The website expect capitalized hash (#Demo) while all the links in the docs use lower case hash (#demo).

@emilk
Copy link
Owner

emilk commented Nov 26, 2024

Thanks, but I think a nicer fix would be to make the hash-matching case insensitive

@tguichaoua
Copy link
Contributor Author

Close in favor of #5446

@tguichaoua tguichaoua closed this Dec 7, 2024
@tguichaoua tguichaoua deleted the doc/fix-link-to-demo branch December 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants