Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glow to 0.16 #5395

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Update glow to 0.16 #5395

merged 3 commits into from
Nov 26, 2024

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Nov 21, 2024

  • I have followed the instructions in the PR template

@sagudev sagudev marked this pull request as ready for review November 22, 2024 08:25
@emilk emilk added egui_glow Relates to running egui_glow on native eframe Relates to epi and eframe and removed eframe Relates to epi and eframe labels Nov 26, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5395-glow16
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@sagudev
Copy link
Contributor Author

sagudev commented Nov 26, 2024

I rebased PR and allow duplicated glow versions in workspace (released wgpu still uses old glow).

@emilk
Copy link
Owner

emilk commented Nov 26, 2024

You need to merge in master (again) to fix CI failures

@sagudev
Copy link
Contributor Author

sagudev commented Nov 26, 2024

suggestion: Might be worth enforcing "The Not Rocket Science Rule Of Software Engineering" (automatically maintain a repository of code that always passes all the tests), by using GitHub Merge Queue.

@emilk emilk merged commit 84cc157 into emilk:master Nov 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe egui_glow Relates to running egui_glow on native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants