Document justification for FallbackEgl #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous link does not explain why we chose FallbackEgl. This is a better link.
|
Preview available at https://egui-pr-preview.github.io/pr/5392-egl |
emilk
approved these changes
Nov 26, 2024
emilk
changed the title
emilk
added
exclude from changelog
eframe
Helyos96
reviewed
Nov 26, 2024
| .with_preference(glutin_winit::ApiPreference::FallbackEgl) // https://github.com/emilk/egui/issues/2520#issuecomment-1367841150 | ||
| // | ||
| // The justification for FallbackEgl over PreferEgl is at https://github.com/emilk/egui/pull/2526#issuecomment-1400229576 . | ||
| .with_preference(glutin_winit::ApiPreference::PreferEgl) |
There was a problem hiding this comment.
Am I misunderstanding something or should this have stayed FallbackEgl ?
There was a problem hiding this comment.
Yes it should have. My bad. I was playing around with this setting to understand it, which is how I ended up updating the documentation comment. I accidentally committed the change when I only wanted to commit the documentation.
lucasmerlin
pushed a commit
that referenced
this pull request
Nov 30, 2024
I accidentally changed this in a previous commit when I meant to only change the comment above it. #5392 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous link does not explain why we chose FallbackEgl. This is a better link.