Always compute pointer position with current zoom #5380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5380-pointer_current_zoom |
emilk
requested changes
Nov 26, 2024
| } | ||
|
|
||
| /// If it is a good idea to show a tooltip, where is pointer? | ||
| #[inline(always)] | ||
| pub fn hover_pos(&self) -> Option<Pos2> { | ||
| self.latest_pos | ||
| self.latest_pos.map(|p| p / self.zoom_factor) |
There was a problem hiding this comment.
This all feels like the wrong solution to me.
In egui, everything is in the same global coordinate space called ui points.
If self.latest_post needs dividing with zoom_factor, that's a bug in how latest_pos is set
There was a problem hiding this comment.
Thanks for your eyes. Indeed my actual problem was already solved, I just hadn't looked around enough. Closing this MR and the linked issue now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses out-of-date pointer positions during changing zoom factors by performing the same zoom-based scaling per-frame when the current zoom factor is known, rather than baking in the zoom factor during the most recent pointer move.
Before:
Screencast.from.2024-11-16.04.09.08.PM.webm
After:
Screencast.from.2024-11-16.04.13.54.PM.webm
See #5379 for discussion and more details