-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accesskit to 0.17 #5372
Update accesskit to 0.17 #5372
Conversation
Preview available at https://egui-pr-preview.github.io/pr/5372-lucas/update-accesskit |
@mwcampbell the update was straightforward, but maybe you can review this in case I missed anything? Especially around the |
I see you dropped two calls to
The other problem is with the part where you use |
@mwcampbell thank you for the review, I've updated the PR accordingly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. I also did a quick test with a screen reader, and all looks right.
Just checking: are you waiting on something else from me before merging? Thanks. |
No, just waiting for @emilk to merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Updates accesskit and kittest.