Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accesskit to 0.17 #5372

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update accesskit to 0.17 #5372

merged 2 commits into from
Nov 26, 2024

Conversation

lucasmerlin
Copy link
Collaborator

Updates accesskit and kittest.

  • I have followed the instructions in the PR template

@lucasmerlin lucasmerlin added accessibility More accessible to e.g. the visually impaired dependencies Pull requests that update a dependency file labels Nov 14, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5372-lucas/update-accesskit
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@lucasmerlin
Copy link
Collaborator Author

@mwcampbell the update was straightforward, but maybe you can review this in case I missed anything?

Especially around the set_default_action_verb, I just removed those calls but am not 100% sure if I need to do anything else there.

@mwcampbell
Copy link
Contributor

I see you dropped two calls to set_default_action_verb:

  • builder.set_default_action_verb(accesskit::DefaultActionVerb::Focus);: This one is no longer necessary.
  • builder.set_default_action_verb(accesskit::DefaultActionVerb::Click);: The if statement surrounding this needs to be re-added, but replace this statement with: builder.add_action(accesskit::Action::Click);.

The other problem is with the part where you use builder.set_label. If the role of the new node is Role::Label, you need to use builder.set_value instead.

@lucasmerlin
Copy link
Collaborator Author

@mwcampbell thank you for the review, I've updated the PR accordingly!

Copy link
Contributor

@mwcampbell mwcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. I also did a quick test with a screen reader, and all looks right.

@mwcampbell
Copy link
Contributor

Just checking: are you waiting on something else from me before merging? Thanks.

@lucasmerlin
Copy link
Collaborator Author

No, just waiting for @emilk to merge this

Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@emilk emilk merged commit e285050 into master Nov 26, 2024
46 checks passed
@emilk emilk deleted the lucas/update-accesskit branch November 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility More accessible to e.g. the visually impaired dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants