Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: Sides did not apply the layout position correctly." #5300

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Oct 23, 2024

Reverts #5232

I should have tested it first. cursor can contain infinites. There is a better fix to be found @zhatuokun

@emilk emilk merged commit 68d312d into master Oct 23, 2024
46 checks passed
@emilk emilk deleted the revert-5232-fix-sides-layout-position branch October 23, 2024 09:18
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5300-revert-5232-fix-sides-layout-position
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@zhatuokun
Copy link
Contributor

That's true, so just use available_rect_before_wrap.

hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…milk#5300)

Reverts emilk#5232

I should have tested it first. `cursor` can contain infinites. There is
a better fix to be found @zhatuokun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants