Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add painter.line() #5291

Merged
merged 3 commits into from
Nov 26, 2024
Merged

add painter.line() #5291

merged 3 commits into from
Nov 26, 2024

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Oct 20, 2024

@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5291-patch5273
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

lucasmerlin
lucasmerlin requested changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! But I'd put this in the /// # Paint different primitives section, where the line_segment function also is.

@lucasmerlin lucasmerlin added feature New feature or request egui labels Oct 20, 2024
@bircni
Copy link
Contributor Author

bircni commented Nov 15, 2024

fixed and merged master into

@bircni bircni requested a review from lucasmerlin November 15, 2024 21:56
lucasmerlin
lucasmerlin approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emilk emilk merged commit 12f9d6f into emilk:master Nov 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmerlin lucasmerlin lucasmerlin approved these changes

Assignees
No one assigned
Labels
egui feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Painter method for line is missing
3 participants
@bircni @lucasmerlin @emilk