Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Table::id_salt on ScrollArea #5282

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Use Table::id_salt on ScrollArea #5282

merged 1 commit into from
Oct 23, 2024

Conversation

jwhear
Copy link
Contributor

@jwhear jwhear commented Oct 17, 2024

The salt is based on the table's state_id.

The salt is based on the table's `state_id`.
Fixes emilk#5281
@lucasmerlin lucasmerlin added bug Something is broken egui_extras labels Oct 19, 2024
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

Preview available at https://egui-pr-preview.github.io/pr/5282-fix_5281
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk merged commit 7c1f069 into emilk:master Oct 23, 2024
25 checks passed
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
The salt is based on the table's `state_id`.

* Closes emilk#5281
* [x] I have followed the instructions in the PR template
@emilk emilk changed the title Use id_salt on Table ScrollArea Use Table::id_salt on ScrollArea Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui_extras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableBuilder id_salt does not result in unique scroll areas
3 participants