egui-wgpu: Fix docs.rs build #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
added
docs and examples
|
Preview available at https://egui-pr-preview.github.io/pr/5204-lucas/5202-egui-wgpu-docs-build-is-failing-since-029 |
YgorSouza
reviewed
Oct 1, 2024
| @@ -37,7 +37,7 @@ default = ["fragile-send-sync-non-atomic-wasm"] | |||
| puffin = ["dep:puffin"] | |||
|
|
|||
| ## Enable [`winit`](https://docs.rs/winit) integration. On Linux, requires either `wayland` or `x11` | |||
| winit = ["dep:winit"] | |||
| winit = ["dep:winit", "winit/rwh_06"] | |||
There was a problem hiding this comment.
Could do the same as eframe for consistency, although it's the same result in the end.
Line 149 in 24cd711
There was a problem hiding this comment.
Looking like it's already enabled for winit in eframe? 🤔
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This enables the rwh_06 feature in winit which is required to correctly build egui-wgpu - fixes emilk#5202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the rwh_06 feature in winit which is required to correctly build egui-wgpu