Fix issue where nested side panels can't be resized larger than their contents #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… content layout rect, even if other size constraints are specified on the panel
|
When testing, let's make sure this doesn't break the auto-sizing of panels |
|
Preview available at https://egui-pr-preview.github.io/pr/5186-pr/fix_nested_side_panel |
It probably does! My bad, also found the docs regarding this behavior on panels when looking for the auto sizing behavior as you mentioned it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a panel could not be resized to a size larger than it's content layout rect when using nested panels. The issue shows both when nesting panels in panels, and when nesting panels in a window. I have created a github project as a repro here:
https://github.com/teddemunnik/egui_inner_panel_repro/blob/master/src/main.rs
egui_bug_before.mp4
egui_bug_after.mp4