Remove wildcard imports

Cargo.toml

@@ -118,6 +118,7 @@ unused_qualifications = "allow"
 [workspace.lints.rustdoc]
 all = "warn"
 missing_crate_level_docs = "warn"
+broken_intra_doc_links = "allow"
 
 # See also clippy.toml
 [workspace.lints.clippy]
@@ -248,6 +249,7 @@ use_self = "warn"
 useless_transmute = "warn"
 verbose_file_reads = "warn"
 wildcard_dependencies = "warn"
+wildcard_imports = "warn"                   # we did this a lot in egui
 zero_sized_map_values = "warn"
 
 # TODO(emilk): enable more of these lints:
@@ -262,4 +264,3 @@ unwrap_used = "allow"                 # TODO(emilk): We really wanna warn on thi
 manual_range_contains = "allow"       # this one is just worse imho
 self_named_module_files = "allow"     # Disabled waiting on https://github.com/rust-lang/rust-clippy/issues/9602
 significant_drop_tightening = "allow" # Too many false positives
-wildcard_imports = "allow"            # we do this a lot in egui

crates/ecolor/src/cint_impl.rs

@@ -1,4 +1,4 @@
-use super::*;
+use super::{linear_f32_from_linear_u8, linear_u8_from_linear_f32, Color32, Hsva, HsvaGamma, Rgba};
 use cint::{Alpha, ColorInterop, EncodedSrgb, Hsv, LinearSrgb, PremultipliedAlpha};
 
 // ---- Color32 ----

crates/eframe/src/lib.rs

@@ -474,4 +474,4 @@ mod profiling_scopes {
 }
 
 #[allow(unused_imports)]
-pub(crate) use profiling_scopes::*;
+pub(crate) use profiling_scopes::{profile_function, profile_scope};

crates/eframe/src/native/glow_integration.rs

@@ -1,4 +1,4 @@
-//! Note that this file contains code very similar to [`wgpu_integration`].
+//! Note that this file contains code very similar to [`super::wgpu_integration`].
 //! When making changes to one you often also want to apply it to the other.
 //!
 //! This is also very complex code, and not very pretty.
@@ -36,13 +36,13 @@ use egui::{
 use egui_winit::accesskit_winit;
 
 use crate::{
-    native::{epi_integration::EpiIntegration, winit_integration::create_egui_context},
-    App, AppCreator, CreationContext, NativeOptions, Result, Storage,
+    native::epi_integration::EpiIntegration, App, AppCreator, CreationContext, NativeOptions,
+    Result, Storage,
 };
 
 use super::{
-    winit_integration::{EventResult, UserEvent, WinitApp},
-    *,
+    epi_integration, event_loop_context,
+    winit_integration::{create_egui_context, EventResult, UserEvent, WinitApp},
 };
 
 // ----------------------------------------------------------------------------
@@ -462,6 +462,8 @@ impl WinitApp for GlowWinitApp {
 
     #[cfg(feature = "accesskit")]
     fn on_accesskit_event(&mut self, event: accesskit_winit::Event) -> crate::Result<EventResult> {
+        use super::winit_integration;
+
         if let Some(running) = &self.running {
             let mut glutin = running.glutin.borrow_mut();
             if let Some(viewport_id) = glutin.viewport_from_window.get(&event.window_id).copied() {

crates/eframe/src/native/wgpu_integration.rs

@@ -1,4 +1,4 @@
-//! Note that this file contains code very similar to [`glow_integration`].
+//! Note that this file contains code very similar to [`super::glow_integration`].
 //! When making changes to one you often also want to apply it to the other.
 //!
 //! This is also very complex code, and not very pretty.
@@ -29,7 +29,7 @@ use crate::{
     App, AppCreator, CreationContext, NativeOptions, Result, Storage,
 };
 
-use super::{winit_integration::WinitApp, *};
+use super::{epi_integration, event_loop_context, winit_integration, winit_integration::WinitApp};
 
 // ----------------------------------------------------------------------------
 // Types:

crates/eframe/src/web/events.rs

@@ -1,4 +1,9 @@
-use super::*;
+use super::{
+    button_from_mouse_event, location_hash, modifiers_from_kb_event, modifiers_from_mouse_event,
+    modifiers_from_wheel_event, pos_from_mouse_event, prefers_color_scheme_dark, primary_touch_pos,
+    push_touches, text_from_keyboard_event, theme_from_dark_mode, translate_key, AppRunner,
+    Closure, JsCast, JsValue, WebRunner,
+};
 use web_sys::EventTarget;
 
 // TODO(emilk): there are more calls to `prevent_default` and `stop_propagaton`

crates/eframe/src/web/mod.rs

@@ -43,7 +43,11 @@ pub use backend::*;
 use wasm_bindgen::prelude::*;
 use web_sys::MediaQueryList;
 
-use input::*;
+use input::{
+    button_from_mouse_event, modifiers_from_kb_event, modifiers_from_mouse_event,
+    modifiers_from_wheel_event, pos_from_mouse_event, primary_touch_pos, push_touches,
+    text_from_keyboard_event, translate_key,
+};
 
 // ----------------------------------------------------------------------------
 

crates/egui-wgpu/src/lib.rs

@@ -433,4 +433,4 @@ mod profiling_scopes {
 }
 
 #[allow(unused_imports)]
-pub(crate) use profiling_scopes::*;
+pub(crate) use profiling_scopes::{profile_function, profile_scope};

crates/egui-winit/src/lib.rs

@@ -26,7 +26,7 @@ use ahash::HashSet;
 use raw_window_handle::HasDisplayHandle;
 
 #[allow(unused_imports)]
-pub(crate) use profiling_scopes::*;
+pub(crate) use profiling_scopes::{profile_function, profile_scope};
 
 use winit::{
     dpi::{PhysicalPosition, PhysicalSize},

crates/egui/src/containers/area.rs

@@ -2,7 +2,10 @@
 //! It has no frame or own size. It is potentially movable.
 //! It is the foundation for windows and popups.
 
-use crate::*;
+use crate::{
+    emath, pos2, Align2, Context, Id, InnerResponse, LayerId, NumExt, Order, Pos2, Rect, Response,
+    Sense, Ui, UiBuilder, UiKind, UiStackInfo, Vec2, WidgetRect, WidgetWithState,
+};
 
 /// State of an [`Area`] that is persisted between frames.
 ///
@@ -21,8 +24,8 @@ pub struct AreaState {
     ///
     /// Area size is intentionally NOT persisted between sessions,
     /// so that a bad tooltip or menu size won't be remembered forever.
-    /// A resizable [`Window`] remembers the size the user picked using
-    /// the state in the [`Resize`] container.
+    /// A resizable [`crate::Window`] remembers the size the user picked using
+    /// the state in the [`crate::Resize`] container.
     #[cfg_attr(feature = "serde", serde(skip))]
     pub size: Option<Vec2>,
 
@@ -83,7 +86,7 @@ impl AreaState {
 
 /// An area on the screen that can be moved by dragging.
 ///
-/// This forms the base of the [`Window`] container.
+/// This forms the base of the [`crate::Window`] container.
 ///
 /// ```
 /// # egui::__run_test_ctx(|ctx| {
@@ -232,7 +235,7 @@ impl Area {
     /// If the contents are smaller than this size, the area will shrink to fit the contents.
     /// If the contents overflow, the area will grow.
     ///
-    /// If not set, [`style::Spacing::default_area_size`] will be used.
+    /// If not set, [`crate::style::Spacing::default_area_size`] will be used.
     #[inline]
     pub fn default_size(mut self, default_size: impl Into<Vec2>) -> Self {
         self.default_size = default_size.into();

crates/egui/src/containers/collapsing_header.rs

@@ -1,6 +1,9 @@
 use std::hash::Hash;
 
-use crate::*;
+use crate::{
+    emath, epaint, pos2, remap, remap_clamp, vec2, Context, Id, InnerResponse, NumExt, Rect,
+    Response, Sense, Stroke, TextStyle, TextWrapMode, Ui, Vec2, WidgetInfo, WidgetText, WidgetType,
+};
 use epaint::Shape;
 
 #[derive(Clone, Copy, Debug)]
@@ -15,7 +18,7 @@ pub(crate) struct InnerState {
 
 /// This is a a building block for building collapsing regions.
 ///
-/// It is used by [`CollapsingHeader`] and [`Window`], but can also be used on its own.
+/// It is used by [`CollapsingHeader`] and [`crate::Window`], but can also be used on its own.
 ///
 /// See [`CollapsingState::show_header`] for how to show a collapsing header with a custom header.
 #[derive(Clone, Debug)]

crates/egui/src/containers/combo_box.rs

@@ -1,6 +1,10 @@
 use epaint::Shape;
 
-use crate::{style::WidgetVisuals, *};
+use crate::{
+    epaint, style::WidgetVisuals, vec2, Align2, Context, Id, InnerResponse, NumExt, Painter,
+    PopupCloseBehavior, Rect, Response, ScrollArea, Sense, Stroke, TextStyle, TextWrapMode, Ui,
+    UiBuilder, Vec2, WidgetInfo, WidgetText, WidgetType,
+};
 
 #[allow(unused_imports)] // Documentation
 use crate::style::Spacing;
@@ -150,7 +154,7 @@ impl ComboBox {
 
     /// Controls the wrap mode used for the selected text.
     ///
-    /// By default, [`Ui::wrap_mode`] will be used, which can be overridden with [`Style::wrap_mode`].
+    /// By default, [`Ui::wrap_mode`] will be used, which can be overridden with [`crate::Style::wrap_mode`].
     ///
     /// Note that any `\n` in the text will always produce a new line.
     #[inline]

crates/egui/src/containers/frame.rs

@@ -1,7 +1,10 @@
 //! Frame container
 
-use crate::{layers::ShapeIdx, *};
-use epaint::*;
+use crate::{
+    epaint, layers::ShapeIdx, InnerResponse, Response, Sense, Style, Ui, UiBuilder, UiKind,
+    UiStackInfo,
+};
+use epaint::{Color32, Margin, Rect, Rounding, Shadow, Shape, Stroke};
 
 /// Add a background, frame and/or margin to a rectangular background of a [`Ui`].
 ///

crates/egui/src/containers/panel.rs

@@ -3,7 +3,7 @@
 //! Panels can either be a child of a [`Ui`] (taking up a portion of the parent)
 //! or be top-level (taking up a portion of the whole screen).
 //!
-//! Together with [`Window`] and [`Area`]:s, top-level panels are
+//! Together with [`crate::Window`] and [`crate::Area`]:s, top-level panels are
 //! the only places where you can put you widgets.
 //!
 //! The order in which you add panels matter!
@@ -13,9 +13,12 @@
 //!
 //! ⚠ Always add any [`CentralPanel`] last.
 //!
-//! Add your [`Window`]:s after any top-level panels.
+//! Add your [`crate::Window`]:s after any top-level panels.
 
-use crate::*;
+use crate::{
+    lerp, vec2, Align, Context, CursorIcon, Frame, Id, InnerResponse, LayerId, Layout, NumExt,
+    Rangef, Rect, Sense, Stroke, Ui, UiBuilder, UiKind, UiStackInfo, Vec2,
+};
 
 fn animate_expansion(ctx: &Context, id: Id, is_expanded: bool) -> f32 {
     ctx.animate_bool_responsive(id, is_expanded)
@@ -135,9 +138,9 @@ impl SidePanel {
     /// If you want your panel to be resizable you also need a widget in it that
     /// takes up more space as you resize it, such as:
     /// * Wrapping text ([`Ui::horizontal_wrapped`]).
-    /// * A [`ScrollArea`].
-    /// * A [`Separator`].
-    /// * A [`TextEdit`].
+    /// * A [`crate::ScrollArea`].
+    /// * A [`crate::Separator`].
+    /// * A [`crate::TextEdit`].
     /// * …
     #[inline]
     pub fn resizable(mut self, resizable: bool) -> Self {
@@ -613,9 +616,9 @@ impl TopBottomPanel {
     /// If you want your panel to be resizable you also need a widget in it that
     /// takes up more space as you resize it, such as:
     /// * Wrapping text ([`Ui::horizontal_wrapped`]).
-    /// * A [`ScrollArea`].
-    /// * A [`Separator`].
-    /// * A [`TextEdit`].
+    /// * A [`crate::ScrollArea`].
+    /// * A [`crate::Separator`].
+    /// * A [`crate::TextEdit`].
     /// * …
     #[inline]
     pub fn resizable(mut self, resizable: bool) -> Self {
@@ -633,7 +636,7 @@ impl TopBottomPanel {
     }
 
     /// The initial height of the [`TopBottomPanel`], including margins.
-    /// Defaults to [`style::Spacing::interact_size`].y, plus frame margins.
+    /// Defaults to [`crate::style::Spacing::interact_size`].y, plus frame margins.
     #[inline]
     pub fn default_height(mut self, default_height: f32) -> Self {
         self.default_height = Some(default_height);
@@ -1041,7 +1044,7 @@ impl TopBottomPanel {
 ///
 /// ⚠ [`CentralPanel`] must be added after all other panels!
 ///
-/// NOTE: Any [`Window`]s and [`Area`]s will cover the top-level [`CentralPanel`].
+/// NOTE: Any [`crate::Window`]s and [`crate::Area`]s will cover the top-level [`CentralPanel`].
 ///
 /// See the [module level docs](crate::containers::panel) for more details.
 ///

crates/egui/src/containers/popup.rs

@@ -2,7 +2,11 @@
 
 use frame_state::PerWidgetTooltipState;
 
-use crate::*;
+use crate::{
+    frame_state, vec2, AboveOrBelow, Align, Align2, Area, AreaState, Context, Frame, Id,
+    InnerResponse, Key, LayerId, Layout, Order, Pos2, Rect, Response, Sense, Ui, UiKind, Vec2,
+    Widget, WidgetText,
+};
 
 // ----------------------------------------------------------------------------
 
@@ -322,14 +326,14 @@ pub fn was_tooltip_open_last_frame(ctx: &Context, widget_id: Id) -> bool {
 pub enum PopupCloseBehavior {
     /// Popup will be closed on click anywhere, inside or outside the popup.
     ///
-    /// It is used in [`ComboBox`].
+    /// It is used in [`crate::ComboBox`].
     CloseOnClick,
 
     /// Popup will be closed if the click happened somewhere else
     /// but in the popup's body
     CloseOnClickOutside,
 
-    /// Clicks will be ignored. Popup might be closed manually by calling [`Memory::close_popup`]
+    /// Clicks will be ignored. Popup might be closed manually by calling [`crate::Memory::close_popup`]
     /// or by pressing the escape button
     IgnoreClicks,
 }
@@ -358,7 +362,7 @@ pub fn popup_below_widget<R>(
 ///
 /// The opened popup will have a minimum width matching its parent.
 ///
-/// You must open the popup with [`Memory::open_popup`] or  [`Memory::toggle_popup`].
+/// You must open the popup with [`crate::Memory::open_popup`] or  [`crate::Memory::toggle_popup`].
 ///
 /// Returns `None` if the popup is not open.
 ///

crates/egui/src/containers/resize.rs

@@ -1,4 +1,7 @@
-use crate::*;
+use crate::{
+    pos2, vec2, Align2, Color32, Context, CursorIcon, Id, NumExt, Rect, Response, Sense, Shape, Ui,
+    UiBuilder, UiKind, UiStackInfo, Vec2, Vec2b,
+};
 
 #[derive(Clone, Copy, Debug)]
 #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
@@ -88,7 +91,7 @@ impl Resize {
     /// Preferred / suggested height. Actual height will depend on contents.
     ///
     /// Examples:
-    /// * if the contents is a [`ScrollArea`] then this decides the maximum size.
+    /// * if the contents is a [`crate::ScrollArea`] then this decides the maximum size.
     /// * if the contents is a canvas, this decides the height of it,
     /// * if the contents is text and buttons, then the `default_height` is ignored
     ///   and the height is picked automatically..

crates/egui/src/containers/scroll_area.rs

@@ -1,6 +1,9 @@
 #![allow(clippy::needless_range_loop)]
 
-use crate::*;
+use crate::{
+    emath, epaint, frame_state, lerp, pos2, remap, remap_clamp, vec2, Context, Id, NumExt, Pos2,
+    Rangef, Rect, Sense, Ui, UiBuilder, UiKind, UiStackInfo, Vec2, Vec2b,
+};
 
 #[derive(Clone, Copy, Debug)]
 #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
@@ -157,7 +160,7 @@ impl ScrollBarVisibility {
 /// # });
 /// ```
 ///
-/// You can scroll to an element using [`Response::scroll_to_me`], [`Ui::scroll_to_cursor`] and [`Ui::scroll_to_rect`].
+/// You can scroll to an element using [`crate::Response::scroll_to_me`], [`Ui::scroll_to_cursor`] and [`Ui::scroll_to_rect`].
 #[derive(Clone, Debug)]
 #[must_use = "You should call .show()"]
 pub struct ScrollArea {
@@ -367,7 +370,7 @@ impl ScrollArea {
     /// * If `false`, the scroll area will not respond to user scrolling.
     ///
     /// This can be used, for example, to optionally freeze scrolling while the user
-    /// is typing text in a [`TextEdit`] widget contained within the scroll area.
+    /// is typing text in a [`crate::TextEdit`] widget contained within the scroll area.
     ///
     /// This controls both scrolling directions.
     #[inline]

crates/egui/src/containers/window.rs

@@ -3,10 +3,13 @@
 use std::sync::Arc;
 
 use crate::collapsing_header::CollapsingState;
-use crate::*;
-use epaint::*;
+use crate::{
+    Align, Align2, Context, CursorIcon, Id, InnerResponse, LayerId, NumExt, Order, Response, Sense,
+    TextStyle, Ui, UiKind, Vec2b, WidgetRect, WidgetText,
+};
+use epaint::{emath, pos2, vec2, Galley, Pos2, Rect, RectShape, Rounding, Shape, Stroke, Vec2};
 
-use super::*;
+use super::{area, resize, Area, Frame, Resize, ScrollArea};
 
 /// Builder for a floating window which can be dragged, closed, collapsed, resized and scrolled (off by default).
 ///