-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Positioning issues with Slider and other Button. #4937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbasic
changed the title
Fix: When
Fix: Positioning issues with Slider and other Button.
Aug 10, 2024
ui.slider()
is inside ui.horizontal()
, the DragValue button position moves down slightly.
bircni
approved these changes
Aug 16, 2024
emilk
reviewed
Aug 26, 2024
Comment on lines
+76
to
+87
ui.horizontal(|ui| { | ||
ui.add(Slider::new(&mut self.image_options.uv.min.x, 0.0..=1.0).text("min x")); | ||
}); | ||
ui.horizontal(|ui| { | ||
ui.add(Slider::new(&mut self.image_options.uv.min.y, 0.0..=1.0).text("min y")); | ||
}); | ||
ui.horizontal(|ui| { | ||
ui.add(Slider::new(&mut self.image_options.uv.max.x, 0.0..=1.0).text("max x")); | ||
}); | ||
ui.horizontal(|ui| { | ||
ui.add(Slider::new(&mut self.image_options.uv.max.y, 0.0..=1.0).text("max y")); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Users should not need to wrap all their sliders in horizontal layouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue: Positioning issues with Slider and other Button.
Fix Issue: When
ui.slider()
is insideui.horizontal()
, the DragValue button position moves down slightly.Improvement:
.text_style_height(&ui.style().drag_value_text_style)
Improvement:
button_padding
appliedIf there are multiple
SliderOrientation::Vertical
s, things can get a little tricky to handle.Before :
https://github.com/user-attachments/assets/3f8120aa-cf92-4383-a038-c3af4b768ce0
After :
https://github.com/user-attachments/assets/f0f037ff-5fd7-42bf-b9b6-277951232edc
Test Example :