Refactor: use if let instead of for on Options
#4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Aug 26, 2024
emilk
changed the title
rust-analyzerif let instead of for on Options
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
This is recommended by `rust-analyzer` It might be a good idea to fix this to appease `rust-analyzer`.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This is recommended by `rust-analyzer` It might be a good idea to fix this to appease `rust-analyzer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is recommended by
rust-analyzerIt might be a good idea to fix this to appease
rust-analyzer.