Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close_button option to test_viewports #4907

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add close_button option to test_viewports #4907

merged 3 commits into from
Aug 26, 2024

Conversation

pm100
Copy link
Contributor

@pm100 pm100 commented Aug 3, 2024

This make the test excercise the window recreation logic, that resulted in several bugs - see #4862

Adds a check box that turns the close button on and off for child windows

@pm100 pm100 mentioned this pull request Aug 3, 2024
Merged
@emilk emilk added the tests Unit tests, regression tests, manual tests, … label Aug 5, 2024
@emilk
Copy link
Owner

emilk commented Aug 5, 2024

Thanks!

@pm100
Copy link
Contributor Author

pm100 commented Aug 5, 2024

@emilk - this allows full testing of the issues associated with #4862. You can see the different behaviors with mac, linux, windows and with wgpu or glow. I believe my PR fixes them all (I have now tested on linux)

PS, can you please look at discussion #4871, I am stuck

@emilk emilk merged commit 06f88e1 into emilk:master Aug 26, 2024
18 of 20 checks passed
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@pm100 @486c
Add close_button option to test_viewports (emilk#4907)
b7581ba 
This make the test excercise the window recreation logic, that resulted
in several bugs - see emilk#4862

Adds a check box that turns the close button on and off for child
windows
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@pm100 @hacknus
Add close_button option to test_viewports (emilk#4907)
fed4e3d 
This make the test excercise the window recreation logic, that resulted
in several bugs - see emilk#4862

Adds a check box that turns the close button on and off for child
windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog tests Unit tests, regression tests, manual tests, …
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pm100 @emilk