Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure SVGs are crisp #4823

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Make sure SVGs are crisp #4823

merged 2 commits into from
Jul 15, 2024

Conversation

aurexav
Copy link
Contributor

@aurexav aurexav commented Jul 13, 2024 •
edited
Loading

I'm fairly new to egui.

I read the code, but I didn't follow the approach mentioned in #3453 (comment).

I believe this is an easier way to achieve that, though I'm not certain if it's the best method.

image

I get really nice svg with this patch.

@emilk Can you please take a look? I really need this!

@aurexav
Copy link
Contributor Author

aurexav commented Jul 13, 2024

It's interesting that some of the indents are tabs while others are 4-spaces.

Would you like me to fix that?

emilk
emilk approved these changes Jul 14, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

But the (false, false) => branch in fn hint should also fall back to Scale(pixels_per_point).

It would also be good to add a comment to SizeHint that its units are in image texels, and that pixels_per_point has already been taken into account.

@emilk emilk changed the title Consider the pixels per point Make sure SVGs are crisp Jul 14, 2024
@emilk emilk added bug Something is broken egui labels Jul 14, 2024
@emilk emilk added this to the Next Patch Release milestone Jul 14, 2024
@emilk emilk merged commit 1741f0a into emilk:master Jul 15, 2024
19 checks passed
@aurexav aurexav deleted the master_ branch July 16, 2024 02:31
lucasmerlin pushed a commit to lucasmerlin/egui that referenced this pull request Jul 30, 2024
@aurexav @lucasmerlin
Make sure SVGs are crisp (emilk#4823)
b59c4c1 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to test and add commits to your PR.
* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#3453
* [x] I have followed the instructions in the PR template

I'm fairly new to egui.

I read the code, but I didn't follow the approach mentioned in
emilk#3453 (comment).

I believe this is an easier way to achieve that, though I'm not certain
if it's the best method.

<img width="760" alt="image"
src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480">

I get really nice svg with this patch.

@emilk Can you please take a look? I really need this!
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@aurexav @486c
Make sure SVGs are crisp (emilk#4823)
50e06a6 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to test and add commits to your PR.
* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#3453
* [x] I have followed the instructions in the PR template

I'm fairly new to egui.

I read the code, but I didn't follow the approach mentioned in
emilk#3453 (comment).

I believe this is an easier way to achieve that, though I'm not certain
if it's the best method.

<img width="760" alt="image"
src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480">

I get really nice svg with this patch.

@emilk Can you please take a look? I really need this!
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@aurexav @hacknus
Make sure SVGs are crisp (emilk#4823)
5dac0e6 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to test and add commits to your PR.
* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#3453
* [x] I have followed the instructions in the PR template

I'm fairly new to egui.

I read the code, but I didn't follow the approach mentioned in
emilk#3453 (comment).

I believe this is an easier way to achieve that, though I'm not certain
if it's the best method.

<img width="760" alt="image"
src="https://github.com/user-attachments/assets/4b3c561f-1c24-446b-9581-a2f4e9858480">

I get really nice svg with this patch.

@emilk Can you please take a look? I really need this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui_extras egui
Projects
None yet
Milestone
Next Patch Release
Development

Successfully merging this pull request may close these issues.

SVG images are blurry when ctx.pixel_per_point is not equal to 1.0
2 participants
@aurexav @emilk