Fix hello_world_par example on Linux #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example does not use the default features from eframe in order to avoid accesskit, which panics when run from multiple threads, so it must manually enable the other default features in order to compile correctly on Linux.
YgorSouza
commented
Jun 20, 2024
| # This is normally enabled by eframe/default, which is not being used here | ||
| # because of accesskit, as mentioned above | ||
| winit = { workspace = true, features = [ | ||
| "default" |
There was a problem hiding this comment.
The example works without this, but the window frame looks different, so I added it to make it match the other examples.
With winit/default
Without winit/default
emilk
approved these changes
Jun 21, 2024
emilk
added
docs and examples
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This example does not use the default features from eframe in order to avoid accesskit, which panics when run from multiple threads, so it must manually enable the other default features in order to compile correctly on Linux. * Closes <emilk#4682>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example does not use the default features from eframe in order to avoid accesskit, which panics when run from multiple threads, so it must manually enable the other default features in order to compile correctly on Linux.