Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragging of custom_window_frame example on Windows #4656

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Jun 13, 2024

Fix dragging of custom_window_frame on Windows (re-edited)

@emilk
Copy link
Owner

emilk commented Jun 18, 2024

Have you tested this on X11?

@rustbasic
Copy link
Contributor Author

Have you tested this on X11?

no.
Tested on Windows.
Since there doesn't seem to be any particular problem with has_focus(),
I don't expect any problems elsewhere.

@emilk emilk added docs and examples Improving and adding documentation and examples exclude from changelog labels Jun 19, 2024
@emilk emilk changed the title Fix dragging of custom_window_frame on Windows (re-edited) Fix dragging of custom_window_frame on Windows Jun 19, 2024
@emilk emilk changed the title Fix dragging of custom_window_frame on Windows Fix dragging of custom_window_frame example on Windows Jun 19, 2024
@emilk emilk merged commit d9c5fb0 into emilk:master Jun 19, 2024
20 of 21 checks passed
@ardocrat
Copy link

ardocrat commented Jun 24, 2024

Tested on Linux, seems like we have a problem with app window resize as with dragging, egui is not receiving event on mouse button release. I need to click somewhere so drag_stopped event will be called. Also related to #2548

@rustbasic rustbasic deleted the patch65 branch August 7, 2024 15:03
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
* Related emilk#4592 
* Closes emilk#4647 

Fix dragging of custom_window_frame on Windows (re-edited)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and examples Improving and adding documentation and examples exclude from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants