Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy way to draw circle arcs #4426

Closed
wants to merge 1 commit into from

Conversation

murl-digital
Copy link
Contributor

@murl-digital murl-digital commented Apr 27, 2024

This PR is related to the discussion in #4188, however it doesn't resolve the issue. It does, however, add a way to draw arcs on a circle. A couple things which need discussion:

  • AngleIter can, in it's current state, loop infinitely. I'm not sure what the best way to handle this is.
  • Using this method, it can sometimes be difficult to get the arc to behave the way you want. For example, drawing a track for a dial requires you to rather unintuitively provide a start and end angle of 225 and -45.
  • The documentation could use some better wording, but I'm not sure how best to communicate its quirks.

@YgorSouza
Copy link
Contributor

Looks like there might be some conflict between this and #4424.

@murl-digital
Copy link
Contributor Author

Looks like there might be some conflict between this and #4424.

yep, closing mine in favor of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants