Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp window size to monitor size by default on all platforms #4410

Merged
merged 4 commits into from
May 10, 2024
Merged

Clamp window size to monitor size by default on all platforms #4410

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e43930
Update epi_integration.rs
rustbasic Apr 25, 2024
3cdb98b
Update epi_integration.rs
rustbasic Apr 25, 2024
dc7aea8
Merge branch 'emilk:master' into patch47
rustbasic Apr 26, 2024
8bc0585
improve comment
emilk May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/eframe/src/native/epi_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ pub fn viewport_builder<E>(

let mut viewport_builder = native_options.viewport.clone();

let clamp_size_to_monitor_size = viewport_builder.clamp_size_to_monitor_size.unwrap_or(
// On some Linux systems, a window size larger than the monitor causes crashes
cfg!(target_os = "linux"),
);
// On some Linux systems, a window size larger than the monitor causes crashes,
// and on Windows the window does not appear at all.
let clamp_size_to_monitor_size = viewport_builder.clamp_size_to_monitor_size.unwrap_or(true);

// Always use the default window size / position on iOS. Trying to restore the previous position
// causes the window to be shown too small.
Expand Down
Loading