Fix scaling of rounded corners for rect shape #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope I didn't miss anything, I haven't really done this before. I now see I probably should have referenced this PR from my commits instead of the issue. Oh well... |
emilk
approved these changes
Mar 12, 2024
emilk
changed the title
emilk
changed the title
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
When scaling an `egui::Shape` of variant `Rect` using the new `transform` function, corner rounding isn't taken into account. The fix is to multiply the rounding by the scaling factor. * Closes <emilk#4152>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scaling an
egui::Shapeof variantRectusing the newtransformfunction, corner rounding isn't taken into account.The fix is to multiply the rounding by the scaling factor.