Fix StripBuilder not allocating its used space
#3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reverted code was introduced in: It seems like table row selection still works after reverting those lines, so 👍 |
emilk
changed the title
StripBuilder not allocating its used space
emilk
approved these changes
Feb 5, 2024
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
At crates\egui_extras\src\layout.rs : Allocate allocation_rect instead of max_rect. Go back from this: ``` let response = self.ui.allocate_rect(max_rect, self.sense); let response = response.with_new_rect(allocation_rect); return (used_rect, response) ``` to this: ``` let response = self.ui.allocate_rect(allocation_rect, self.sense); return (used_rect, response) ``` In order to allocate the Closes <emilk#3956>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At crates\egui_extras\src\layout.rs :
Allocate allocation_rect instead of max_rect.
Go back from this:
to this:
In order to allocate the
Closes #3956.