[discuss] automatically enable egui-winit clipboard feature
#3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This chooses a different tradeoff where it is more easily possible to get rid of x11 or wayland dependencies when they are not needed. Otherwise, when you want `clipboard` and `x11` you will still pull in lots of wayland dependencies for wayland clipboard support that will not be used anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same effort that led to #3946, I noticed that enabling
clipboardleads to lots of wayland dependencies being pulled in even when I just want to build for x11.I guess, the current design is caused by the fact that it is not possible (I think) to have features declarations in cargo to say "only add this dependency if both of these features are enabled" (e.g.
x11andclipboardin this case).This chooses a different tradeoff where clipboard gets automatically enabled when choosing
x11orwaylandbut only for the window system chosen.Let me know if I'm completely on the wrong track here or something else would be breaking.
(This probably needs a warning about the deprecation?)