Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response.context_menu now returns the response of the context menu, if open #3904

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Response.context_menu now returns the response of the context menu, if open #3904

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7017947
Fix: `context menu` requires now a reference to self
AufarZakiev Jan 26, 2024
cf84309
Better fix
AufarZakiev Jan 27, 2024
5da3e88
Even better fix
AufarZakiev Jan 27, 2024
8542a27
Merge branch 'master' into fix-context-menu-self-arg
AufarZakiev Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/egui/src/response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,9 +770,8 @@ impl Response {
/// ```
///
/// See also: [`Ui::menu_button`] and [`Ui::close_menu`].
pub fn context_menu(self, add_contents: impl FnOnce(&mut Ui)) -> Self {
menu::context_menu(&self, add_contents);
self
pub fn context_menu(&self, add_contents: impl FnOnce(&mut Ui)) -> Option<InnerResponse<()>> {
menu::context_menu(self, add_contents)
}
}

Expand Down
Loading