-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menubar macOS #3892
base: master
Are you sure you want to change the base?
Fix menubar macOS #3892
Conversation
Wait, what was the problem with the menu bar? |
It always says NSMenuItem instead of the name of the application |
That is indeed very interesting! On Venture it also worked for me, but once I updated to Sonoma (currently 14.1.2) I was noticing this error...) I'll update to 14.2.1 and check again. |
I have updated to the latest version of macOS and this has fixed the issue. This is odd indeed... |
Glad to hear it! It's probably too platform specific too be part of eframe, but it would be good if eframe users could still add it themselves if they want too. |
I noticed that on macOS the menubar is not looking right anymore:
This PR applies some changes, it would further also allow for a "Settings" window to be implemented, if there would be an egui container for that (we would only need to create a new item in
app_icons.rs
).The menu bar now looks like this:
TODO: