Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menubar macOS #3892

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix menubar macOS #3892

wants to merge 7 commits into from

Conversation

hacknus
Copy link
Contributor

@hacknus hacknus commented Jan 26, 2024

I noticed that on macOS the menubar is not looking right anymore:
Bildschirmfoto 2024-01-26 um 07 43 21
This PR applies some changes, it would further also allow for a "Settings" window to be implemented, if there would be an egui container for that (we would only need to create a new item in app_icons.rs).
The menu bar now looks like this:
Bildschirmfoto 2024-01-26 um 09 04 00

TODO:

  • I have not yet managed to replicate the separator lines

@hacknus hacknus marked this pull request as draft January 26, 2024 07:42
@emilk
Copy link
Owner

emilk commented Jan 26, 2024

Wait, what was the problem with the menu bar?

@hacknus
Copy link
Contributor Author

hacknus commented Jan 26, 2024

It always says NSMenuItem instead of the name of the application

@emilk
Copy link
Owner

emilk commented Jan 26, 2024

Oh, weird! On my macOS Sonoma 14.2.1 it works I get the name of the app:

image

@hacknus
Copy link
Contributor Author

hacknus commented Jan 26, 2024

That is indeed very interesting! On Venture it also worked for me, but once I updated to Sonoma (currently 14.1.2) I was noticing this error...) I'll update to 14.2.1 and check again.

@hacknus
Copy link
Contributor Author

hacknus commented Jan 30, 2024

I have updated to the latest version of macOS and this has fixed the issue. This is odd indeed...
On the bright side, I now learned how one could implement a "Settings" menu in macOS (cmd + ,) is this something that is planned as an extension for egui? or not really because this would be too platform specific?

@emilk
Copy link
Owner

emilk commented Feb 1, 2024

Glad to hear it!

It's probably too platform specific too be part of eframe, but it would be good if eframe users could still add it themselves if they want too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants