Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windowing problems when using the x11 feature on Linux #3643

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix windowing problems when using the x11 feature on Linux #3643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6cb5a5
Don't call `set_maximize` each frame on Linux
emilk Nov 27, 2023
74d4aea
Remove the hack completely
emilk Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions crates/egui-winit/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,6 @@ impl State {

self.egui_input.time = Some(self.start_time.elapsed().as_secs_f64());

// TODO remove this in winit 0.29
// This hack make the window outer_position and size to be valid, X11 Only
// That was happending because winit get the window state before the compositor adds decorations!
#[cfg(all(feature = "x11", target_os = "linux"))]
window.set_maximized(window.is_maximized());

// On Windows, a minimized window will have 0 width and height.
// See: https://github.com/rust-windowing/winit/issues/208
// This solves an issue where egui window positions would be changed when minimizing on Windows.
Expand Down
Loading