Fix vertical Slider
regression(?)
#3484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression(?)
In
egui 0.23.0
, this commit and line exactly, the behavior of verticalSlider
's has been swapped.I'm not sure if this was intentional (nothing in the
CHANGELOG.md
).The base used to be the
bottom
, but it is now thetop
.This PR reverts the code calculating the start position and uses
.into()
to convert to the newRangef
.egui 0.23.0
BehaviorHorizontal sliders increment
left <-> right
, vertical sliders incrementtop <-> bottom
:trailing_fill
behavior is incorrect here.current.mp4
Fixed(?) Behavior
Horizontal sliders increment
left <-> right
(same), vertical sliders incrementbottom <-> top
(old behavior):fix.mp4