Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accesskit and accesskit_winit. #3475

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update accesskit and accesskit_winit. #3475

merged 2 commits into from
Nov 10, 2023

Conversation

ndarilek
Copy link
Contributor

No description provided.

@ndarilek ndarilek marked this pull request as ready for review October 16, 2023 20:37
@ndarilek
Copy link
Contributor Author

I'm not clear if I need to add labels to make this pass or not, but I don't appear able to.

In any case, it'd be nice if this could land in a patch release somehow--not sure if a dependency upgrade like this qualifies for that even if there aren't user-facing API changes. Bevy 0.12 releasing soon ships AccessKit 0.12 as well, and I'm hoping to release a bevy_egui integration that gets all of this working in Bevy games. But getting everything on the same version of AccessKit is a bit of a challenge.

Thanks!

@DataTriny
Copy link
Contributor

Hi @ndarilek

Please note that it is mandatory to call accesskit_winit::Adapter::on_event whenever a winit event is received by the app. If false is returned then the event should be discarded before it could be consumed by the app.

Actually this was the case since Unix support was introduced to AccessKit, but it is now a requirement on macOS as well. Not doing so breaks focus tracking on both platforms, as well as hit-testing on Unix.

@ndarilek
Copy link
Contributor Author

Thanks, going to work this in later today. Is there anything else needed for the upgrade? Asking because I'm trying to get Bevy 0.12 upgraded in time for its imminent release and want to make sure there's nothing else that's needed.`

@DataTriny
Copy link
Contributor

You should also populate the new Tree fields:

  • app_name: do egui already have access to that?
  • toolkit_name: egui,
  • toolkit_version: you should be able to fetch it from a Cargo environment variable

These properties are exposed on Windows and Unix to help assistive technologies apply patches to specific toolkits and/or apps.

@mwcampbell
Copy link
Contributor

@ndarilek Do you recall why you modified .github/workflows/rust.yml to install libatk1.0-dev? I don't believe that's actually necessary.

@ndarilek
Copy link
Contributor Author

ndarilek commented Nov 4, 2023

I thought there may have been a related build failure when I did this. If it builds without it, though, then feel free to remove it.

@emilk emilk added the dependencies Pull requests that update a dependency file label Nov 10, 2023
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@emilk emilk merged commit d0ff09a into emilk:master Nov 10, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants