-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accesskit and accesskit_winit. #3475
Conversation
I'm not clear if I need to add labels to make this pass or not, but I don't appear able to. In any case, it'd be nice if this could land in a patch release somehow--not sure if a dependency upgrade like this qualifies for that even if there aren't user-facing API changes. Bevy 0.12 releasing soon ships AccessKit 0.12 as well, and I'm hoping to release a bevy_egui integration that gets all of this working in Bevy games. But getting everything on the same version of AccessKit is a bit of a challenge. Thanks! |
Hi @ndarilek Please note that it is mandatory to call Actually this was the case since Unix support was introduced to AccessKit, but it is now a requirement on macOS as well. Not doing so breaks focus tracking on both platforms, as well as hit-testing on Unix. |
Thanks, going to work this in later today. Is there anything else needed for the upgrade? Asking because I'm trying to get Bevy 0.12 upgraded in time for its imminent release and want to make sure there's nothing else that's needed.` |
You should also populate the new
These properties are exposed on Windows and Unix to help assistive technologies apply patches to specific toolkits and/or apps. |
@ndarilek Do you recall why you modified .github/workflows/rust.yml to install libatk1.0-dev? I don't believe that's actually necessary. |
I thought there may have been a related build failure when I did this. If it builds without it, though, then feel free to remove it. |
No description provided.