eframe: fix unexpected change with winit 0.28 #3382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Nov 10, 2023
There was a problem hiding this comment.
So resizable used to also affect wether not the maximize button was shown, then winit fixed that rather weird behavior?
I think the preferable way to fix this is to introduce a way to control the maximize button in NativeOptions so that eframe users can toggle the two independently of each other.
There is some work towards that in #3172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of winit 0.28, with the addition of the
WindowsButtonsAPI,resizableno longer controls whether the maximize button is enabled or not. So in this pull request, I've made changes here to match the behavior of older versions of winit until we change our API.