Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not taking clipping into account when calculating colum remainder #3357

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Sep 18, 2023

Currently there is a problem with Column::remainder() in that it can only grow but not shrink, even if Column::clip() was set. It seemed to me that a check for Column::clip() was simply missing, but maybe I've missed the reason why this check was not there in the first place?

See #2430 for more info and examples.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me - thanks for the PR!

@emilk emilk added bug Something is broken egui_extras labels Sep 18, 2023
@emilk emilk merged commit ad8b41c into emilk:master Sep 18, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui_extras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Table from egui_extras
2 participants