Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableRow::col_sense #2904

Closed
wants to merge 3 commits into from
Closed

Add TableRow::col_sense #2904

wants to merge 3 commits into from

Conversation

max-huster
Copy link

Add TableRow::col_sense which does the same as TableRow::col but allows to specify a Sense. It allows for detecting clicks on rows

Closes Discussion #1519

@emilk
Copy link
Owner

emilk commented Apr 18, 2023

Great addition, but I would like to see two more things:

A) An example using this
B) A hover-effect on the row (e.g. a framing of it like we have for Button)

@vvv
Copy link
Contributor

vvv commented Jun 7, 2023

B) A hover-effect on the row (e.g. a framing of it like we have for Button)

@emilk Could you provide any hints on how to do that?

I've created a PoC app that uses TableRow::col_sense. You click on a row and its labels change background color:

2023-06-07.23-42-15.mp4

I am struggling to figure out

  • how to highlight the whole row (not just text labels) and
  • how to apply the framing effect to a row...

I would appreciate some hints. 😇

@vvv
Copy link
Contributor

vvv commented Jun 10, 2023

I'm trying to implement framing for table rows. The desired effect should look like this (light grey background for the hovered-over table row; light blue for the selected row):

2023-06-10.23-32-23.mp4

I understand how to frame a button:

  1. determine the size,
  2. allocate,
  3. interact,
  4. paint the background,
  5. paint the rest of the 🦉 button over the background.

But table row is different. A row consists of cells. The rectangle occupied by the row is not known until all the cells of this row are painted. And once they are painted, it is already too late to paint the background! We'll be painting over the cells.

Like on this demo here, where I'm painting over the middle cell:

2023-06-10.11-19-25.mp4

Update: I've started a discussion — #3069.

@vvv
Copy link
Contributor

vvv commented Jun 12, 2023

Related PR: #1554

@emilk
Copy link
Owner

emilk commented Jan 7, 2024

Closed by #3347

@emilk emilk closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants