Skip to content

Commit

Permalink
Release egui_extras 0.24.2 - Fix Table scrolling bug (#3691)
Browse files Browse the repository at this point in the history
Includes:
* #3690

---------

Co-authored-by: Antoine Beyeler <[email protected]>
  • Loading branch information
emilk and abey79 authored Dec 8, 2023
1 parent d8a7955 commit b1721a3
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 14 deletions.
24 changes: 12 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ members = [
edition = "2021"
license = "MIT OR Apache-2.0"
rust-version = "1.72"
version = "0.24.1"
version = "0.24.2"


[profile.release]
Expand Down
4 changes: 4 additions & 0 deletions crates/egui_extras/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ This file is updated upon each release.
Changes since the last release can be found at <https://github.com/emilk/egui/compare/latest...HEAD> or by running the `scripts/generate_changelog.py` script.


## 0.24.2 - 2023-12-08 - `Table` scroll bug fix
* Fix `Table` scrolling bug [#3690](https://github.com/emilk/egui/pull/3690)


## 0.24.1 - 2023-11-30
* Add more years for datepicker [#3599](https://github.com/emilk/egui/pull/3599) (thanks [@vaqxai](https://github.com/vaqxai)!)

Expand Down
3 changes: 2 additions & 1 deletion crates/egui_extras/src/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,8 @@ impl<'a> TableBody<'a> {

/// Add a single row with the given height.
///
/// If you have many thousands of row it can be more performant to instead use [`Self::rows`] or [`Self::heterogeneous_rows`].
/// ⚠️ It is much more performant to use [`Self::rows`] or [`Self::heterogeneous_rows`],
/// as those functions will only render the visible rows.
pub fn row(&mut self, height: f32, add_row_content: impl FnOnce(TableRow<'a, '_>)) {
let top_y = self.layout.cursor.y;
add_row_content(TableRow {
Expand Down

0 comments on commit b1721a3

Please sign in to comment.