Fix high CPU usage on Windows when app is minimized (#3985)

patch #3982
emilk · Feb 6, 2024 · 68eb3db · 68eb3db
1 parent 45e9e8d
commit 68eb3db
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/crates/eframe/src/native/run.rs b/crates/eframe/src/native/run.rs
@@ -192,10 +192,13 @@ fn run_and_return(
 
             if let Some(window) = winit_app.window(*window_id) {
                 log::trace!("request_redraw for {window_id:?}");
-                if !window.is_minimized().unwrap_or(false) {
+                let is_minimized = window.is_minimized().unwrap_or(false);
+                if is_minimized {
+                    false
+                } else {
                     window.request_redraw();
+                    true
                 }
-                true
             } else {
                 log::trace!("No window found for {window_id:?}");
                 false
@@ -347,10 +350,13 @@ fn run_and_exit(
 
             if let Some(window) = winit_app.window(*window_id) {
                 log::trace!("request_redraw for {window_id:?}");
-                if !window.is_minimized().unwrap_or(false) {
+                let is_minimized = window.is_minimized().unwrap_or(false);
+                if is_minimized {
+                    false
+                } else {
                     window.request_redraw();
+                    true
                 }
-                true
             } else {
                 log::trace!("No window found for {window_id:?}");
                 false