Skip to content

Commit

Permalink
fix: add more comments for non ACK #168
Browse files Browse the repository at this point in the history
  • Loading branch information
emiago committed Dec 22, 2024
1 parent 4738d60 commit 4cd2184
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion sip/transaction_client_tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ func (tx *ClientTx) ack() {

// https://github.com/emiago/sipgo/issues/168
// Destination can be FQDN and we do not want to resolve this.
// Still in case reliable connection, this ack will reuse same INVITE connection
// Per https://datatracker.ietf.org/doc/html/rfc3261#section-17.1.1.2
// The ACK MUST be sent to the same address, port, and transport to which the original request was sent
// This is only needed for UDP
ack.SetDestination(tx.origin.Destination())

err := tx.conn.WriteMsg(ack)
Expand Down

0 comments on commit 4cd2184

Please sign in to comment.