Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've found an issue in cleaning up the RTU module state, that happens in one of the following cases of incoming packet:
cbRaw
callback is installed and aEX_PASSTHROUGH
is returned when the frame was not valid, but the CRC was ok;In these cases, the state of the receiver is not correctly reset, and it is impossible to send new packets (e.g. the
send()
always returnsfalse
) until the timeout elapsed. This is because thecleanup()
function only acts afterMODBUSRTU_TIMEOUT_US
timeout.Setting
_slaveId = 0
at the end of thetask()
fixes the issue.It is also probably better to get rid of the
goto
used in thetask()
function and linting it.Thanks!
L